Andrey

Results 75 comments of Andrey

I have never used it, let me try.

I could not install it on my machine. So I guess not this time. We already use mypy and pyright for FOCS python files so we could choose one of...

Could we trigger it from the turn event? We could preserve the state during the game and when loading/starting just sent a current state.

> Aren't the failures sent via e-mail from Github? It depends on the type of event, and who has triggered it. For example I don't see all emails about this...

> I think that there also should be some badge that tells that compilation on master failed. And that image could also be not only on Freeorion readme.md, wiki, but...

The same code that fails here, with error: > Error: Unexpected failure: Error: no webhook is given (no webhook is given) Works in my repo. Maybe something with the secrets....

My bad, "Webhook" name is misleading, it's not a GitHub webhook. Could you add this value to a setting/secrets/actions: https://github.com/freeorion/freeorion/settings/secrets/actions ![изображение](https://github.com/freeorion/freeorion/assets/171597/d58312b2-5d80-4493-9aa3-c6c3090c9abc)

> Name, Secret, or both are as indicated? The new "GitHub Actions Secret", will have the name: "DISCORD_WEBHOOK" and link to Discord as a value. https://github.com/Azure/actions-workflow-samples/blob/master/assets/create-secrets-for-GitHub-workflows.md This secret is used...

> maybe done, again? Still: ``` discord-notify-success / discord Unexpected failure: Error: no webhook is given (no webhook is given) ``` The result should look like that, except that Freeorion...

I am also doing the conversion, probably we will have some conflicts since macros are involved a lot. Here is my changes in macroses: https://github.com/freeorion/freeorion/pull/4619 There are a couple of...