freeorion icon indicating copy to clipboard operation
freeorion copied to clipboard

Published 20 hours ago • verified publisher icon freeorion

[FOCS] Convert VOLP

Open MichaelCourtney opened this issue 1 year ago • 3 comments

MichaelCourtney avatar Jul 14 '23 15:07 MichaelCourtney

I am also doing the conversion, probably we will have some conflicts since macros are involved a lot.

Here is my changes in macroses: https://github.com/freeorion/freeorion/pull/4619

There are a couple of blockers because API is missed.

  1. https://github.com/freeorion/freeorion/pull/4610
  2. Compare visibilities. (Not yet addressed)

Cjkjvfnby avatar Jul 14 '23 16:07 Cjkjvfnby

I am also doing the conversion, probably we will have some conflicts since macros are involved a lot.

I noticed and figured I'd come from the other direction Volp, Ugmors, Trith... I generally watch the commit log so I'll try and correct for any conflicts

MichaelCourtney avatar Jul 14 '23 21:07 MichaelCourtney

In my changes, I have stopped at SP_MISIORLA I'll submit the PR as soon as I'll get the https://github.com/freeorion/freeorion/pull/4603 merged.

Cjkjvfnby avatar Jul 15 '23 00:07 Cjkjvfnby

Superseeded

MichaelCourtney avatar Mar 07 '24 14:03 MichaelCourtney

@MichaelCourtney, superseded by which PR or commit(s)?

Vezzra avatar Mar 10 '24 16:03 Vezzra

superseded by https://github.com/freeorion/freeorion/pull/4603

MichaelCourtney avatar Mar 11 '24 05:03 MichaelCourtney