cjft

Results 28 comments of cjft

> > Duplicate of #1329 too? > > Yes @ChristopherTrimboli already had a pr to fix double tweet issue. We should open his pr and merge his pr first im...

https://github.com/elizaos-plugins/plugin-twitter/releases/tag/v1.0.1 released, includes Typescript types, Cloudflare Blocker fixed, ENVs readme updated... all user issues should be fixed, tested posts, posting good. Cookies working, not relogging each time.

P.S. - seems like passed all tests, omg, nice... just noticed could do same for all client packages: if we like this change, ill do another PR for dynamic client...

hmmm avaer told me that "alot of wrappings" I can make better abstraction for loading dynamic imports... I'll work on. Like a function for it instead. Bit complex because of...

> hmmm avaer told me that "alot of wrappings" I can make better abstraction for loading dynamic imports... I'll work on. Like a function for it instead. Bit complex because...

> Why do it like this? Why not pass a callback to loadPlugin that is `async () => import('my plugin')` OK yeah callback param is better, I'll update.

changed to callback params: https://github.com/elizaOS/eliza/pull/1383/commits/2efee641eb81c7570d78d045bb1ce6b7334737c0

> Probably need to update > > https://github.com/elizaOS/eliza/blob/4c658d7d70433fdcb2feeffe879429eaef10685d/scripts/dev.sh#L45 > > for future plugin devs https://github.com/elizaOS/eliza/pull/1383/commits/c5d4dc494675f11d370500d087273c7294a2ecee updated plugin instructions

> This doesn't work your `loadPlugin` returns null but the function is typed as `Promise` where as the constructor parameter only takes `Plugin[]`. Giving it a null plugin will definately...

OK strictly type loadPlugins with Plugin + mod style, this works and is type compliant however we now have 3 plugins not correctly typed to Plugin that were hidden found:...