eliza icon indicating copy to clipboard operation
eliza copied to clipboard
verified publisher icon elizaOS

feat: handle long tweet

Open tcm390 opened this issue 1 year ago • 4 comments

related: https://github.com/ai16z/eliza/issues/1178

This PR handles long tweets as follows:

  1. Check if the post is a long post. If it’s not, proceed with a normal tweet. Otherwise, use the sendNoteTweet method for long tweets.
  2. If sendNoteTweet fails, truncate the post and fall back to using a normal tweet.

Also this pr fix the double post issue based on cjft PR, I included fix (https://github.com/ai16z/eliza/pull/1329)

test result:

  1. non-verfied user post: https://x.com/IBGDRGNAI/status/1870505476284469692
  2. verified user post: https://x.com/JayChou11879/status/1870505908834615527

tcm390 avatar Dec 21 '24 16:12 tcm390

duplicate of #1335 draft

odilitime avatar Dec 21 '24 18:12 odilitime

Duplicate of #1329 too?

odilitime avatar Dec 21 '24 19:12 odilitime

Duplicate of #1329 too?

Yes @ChristopherTrimboli already had a pr to fix double tweet issue. We should open his pr and merge his pr first: https://github.com/elizaOS/eliza/pull/1329

tcm390 avatar Dec 21 '24 19:12 tcm390

Duplicate of #1329 too?

Yes @ChristopherTrimboli already had a pr to fix double tweet issue. We should open his pr and merge his pr first

im fine, I discussed with TCM, honest mistake, in open-source some saltiness if devs get PRs yoinked, but was legit coincidence, idc that much, just a 1 liner. I feel welcome after TCM chat + role upgrade, not worried.

ChristopherTrimboli avatar Dec 21 '24 19:12 ChristopherTrimboli

resolved conflict and tested

verified account: https://x.com/JayChou11879/status/1872688847106044244 non-verified-account: https://x.com/IBGDRGNAI/status/1872689915114475839

tcm390 avatar Dec 27 '24 17:12 tcm390