ChristopherHX

Results 976 comments of ChristopherHX

> but don't understand how my small changes result into this decreasing. Your change isn't that small 1000 new lines of text without tests from the docker cli. I think...

> ignore the coverage of this file, can't we? No idea, I tried to find out how to do this then landed in the void of closed / old issues....

`setupShell` and `setupWorkingDirectory` shall not replace the step model, instead this probably should move to the `stepRun` struct. Otherwise `runcontext.Steps()` could clone every step, this is probably the fastest path...

Please provide the stacktrace ( you cut the most important part of the log ) and a sample workflow. I cannot reproduce this without additional information requested by the issue...

Thank you for the additional information I see, the secrets are used as job container credentials. Using them in steps doesn't cause a crash. Seems like the post executor should...

My comment on the deactivated setup-node test step is a real issue. Act or the workflow iteself have to santize the output of a workflow command `::add-matcher::` otherwise actions/runner fails...

FYI You are removing `workflow_call` / `workflow_dispatch` `inputs` context support in this PR. I'm already using the `workflow_call` `inputs` context in github-act-runner, on an old version of act without the...

> There was no mapping from inputs on the event to the `inputs` context, right? Correct. That is a feature request for workflow_dispatch, but reusable workflows ( `workflow_call` ) doesn't...

This patch also seem to resolve this issue, but doesn't regress my external project. ```patch From 7e25f6c66fc4b842ea6f398f997b472a3c013831 Mon Sep 17 00:00:00 2001 From: Christopher Homberger Date: Sat, 27 Aug 2022...

> If we just remove setupActionInputs we break remote actions and it's inputs. I mean for me inputs were still working in nodejs and composite actions even in pre steps....