ChristopherHX

Results 976 comments of ChristopherHX

We seem to have multiple nolint formatting in our codebase. I'm not shure, which is our prefered formatting of them. - `//nolint:

Your problem is you get docker in docker, but expecting docker inside a VM. > Is there a way to specify mounted volumes on the act container ? You can,...

Ok I misunderstood, docker-in-docker means running a nested docker daemon inside a container. Act only offers a bind mount of the host docker socket, which causes this problem. E.g. act...

Oh no, windows test got flacky once both Path and PATH are provided to a process. I have no idea how `fix: GetContainerArchive on Folders` increased the failure rate from...

Need to add the full LICENSE of the origin lookpath package

Yes it is ready to review, there are not much changes since your last review. I wait for this PR to land in act, prior doing more mass changes to...

> to not allow users to run on the host, unless we provide a platform parameter. It easy to exploit. ```yaml on: push jobs: _: runs-on: ubuntu-latest container: -self-hosted steps:...

@cplee I need your approval later a second time for this PR, because this PR is not the first in the merge queue we will see a small merge conflict...

Thank you, it was a long way

Decompressing the artifacts on the server really makes sense if you want direct access to the artifacts. > if a file was uploaded as zip already this breaks the client...