Christopher Hermann

Results 46 comments of Christopher Hermann

Correct, sticky scrolling is based purely on indentation. It is planned to provide a extension point so that every language can define a own implementation for the sticky scrolling calculation....

Fixed with #2756 and https://github.com/eclipse-jdt/eclipse.jdt.ui/pull/2149

I think horizontal scrolling (right/left) is meant. On other IDEs this feature can be enabled via a setting. The default is that the sticky lines do not scroll horizontal, as...

@iloveeclipse I had fixed this issue in the past, but we had to revert the changes since you found some issues on Linux: https://github.com/eclipse-platform/eclipse.platform.ui/pull/1690 Could you please check if this...

> I see errors on every popup close: Yes I need to check this, there are also some "SWT Resource was not properly disposed" errors

> I see errors on every popup close: Should be fixed. Is the coloring working on Linux?

@iloveeclipse can you confirm that the coloring is working on linux like expected? MacOS and Windows is working. Then I would merge this change.

If there are no objections I would merge the PR

> Personally I find the focus color to distracting - it grabs too much of my attention while typing. Yes, good point. I will check if we can just change...

I tried using SWT.COLOR_TITLE_INACTIVE_BACKGROUND if the control is not focused, but this is even more worse (at least on MacOS). ![image](https://github.com/user-attachments/assets/6d68d10e-1f0c-48f9-93f5-cd7c22a5995f) So I see two ways to solve the issue:...