Christopher Hermann

Results 46 comments of Christopher Hermann

I would appreciate some assistance on deciding how to proceed with this PR. **Summary** Four new color options are now available in the preferences to style table and tree selections....

> * From a more technical point of view, I would expect that by default the native colors are used and they can optionall be overwriting via preferences. On Windows,...

I achieved the desired behavior, at least for MacOS it's working fine: - System highlight color is set as viewer selection color on the startup of eclipse. - The color...

> Please explain which menus/preferences should be changed in the "Testing" section of this PR for future reference. I can test in Linux if it's ready in the next couple...

> * The system values for "Selection background color for cell viewer without focus" (white) and "Selection foreground color for cell viewer without focus" (gray) don't work well together (look...

> * Some borders are still painted on the right columns when working with cell selection (look at the 4th and 5th column of the screenshot below) Not related to...

For the failing unit test I will need some help. On my local machine I fixed the test by adding the packages as export package: `org.eclipse.jface.internal.text.contentassist;x-internal:=true,` in bundles/org.eclipse.jface.text/META-INF/MANIFEST.MF `org.eclipse.jface.internal.text.contentassist,` as...

> Maybe in this case it could be easier to instantiate the `TableOwnerDrawSupport` via public API (i.e., via `TableOwnerDrawSupport::install(Table)`) instead of providing a more complicated test setup? Done, thanks for...

> There are 16 commits in this PR. That seems like 15 too many… It's called iterative development, should be no problem with the squash and merge function. Since I'm...

I always try to avoid using amend and force push, at least when collaborating with others. But for this PR your are right, I think there are no others working...