Chris Stewart

Results 98 comments of Chris Stewart

> Are we allowed to have such a user name in Linux: `bitcoin-s`? What if you remove the `-`? For context, all of these docker images worked perfectly fine when...

@guizmaii or anyone else that is curious: I finally got to the bottom of this. It appears that builds cannot be automated to produce jlink'd jres on github actions. This...

> @Christewart > > > I finally got to the bottom of this. It appears that builds cannot be automated to produce jlink'd jres on github actions. This is because...

Our workaround in bitcoin-s: https://github.com/bitcoin-s/bitcoin-s/pull/4377

@luke-jr By your definition of 'valid' isn't any 1 byte value 'valid'?

@luke-jr I've added a test case to inside of script_tests.cpp to test this, and the test case fails when we use `OP_1NEGATE`. Can you elaborate further on what you mean?...

@luke-jr It does not allow a witness script to be spent properly, which is what the context of this BIP is no? You cannot have OP_1NEGATE as a valid witness...

Just for some context of other possible use cases, our lapp allows for users to be refunded for market data subscriptions that are not completely consumed. For instance, if a...

An example of what a websocket market data subscription request looks like ``` { "event": "subscribe", "channel": "tickers", "symbol": "BTCUSDT", "exchange": "binance", "duration": 120000, "refundInvoice": "lnbc1pw80c5app58wamf585fnw5h4fagnqc4tf05mv2mvjuz3qvuhgdu9ur6psmmjvqdpl235hqurfdcs8gmmjddjkcun0vaehgctyyq58g6tswp5kutndv55jsaf3xcenz2gcqzysxqyz5vqe8clzl393uhp3m42k98h4we72ceetrsts3pj0h5w9efklltunk7hfv0g8qjv4dtelxnq0cl0l7ejs9we2kwrr5wguf3rnu8uq5q90uqq8ed279", "uuid": "f3dd7508-8f50-40b3-be51-5ec853f1a546" } ```...

This seems to fix my performance issues on my m1 mac when running tests against bitcoind. This is on the official v23 release (36 seconds) This is on d216d714aae36e6f1c95f82aef81a0be74dee2f3 (!5...