Chris Thrasher

Results 360 comments of Chris Thrasher

> Is there already a way to globally define that sf::Strings always interpret plain strings as UTF-8? There is not. > Support std::u8string, so that at least the following will...

See https://github.com/SFML/SFML/pull/3151 for a potential fix or at least an improvement from the status quo.

https://en.cppreference.com/w/cpp/language/copy_elision C++17's copy elision rules mean I don't think this would add any copies.

CSFML ought to use a `CSFML` prefix for its headers. I think that's a better solution that using an ambiguous file extension. I'm aware we can't do this in CSFML...

> I guess for CSFML 3 it's okay to move everything to `CSFML/` https://github.com/SFML/CSFML/compare/master...include_dir Here's a patch that changes the SFML/ directory prefix to CSFML/. If you like this I'll...

The C interface doesn’t know anything about how the type is defined. That’s why we’re allowed to do this.

Because I need PlotLineG because my data is in a struct that must be unpacked via a getter function. My vector of structures must be kept non-const just for the...

``` .../sfml/extlibs/headers/stb_image/stb_image_write.h:1263:14: runtime error: left shift of negative value -521666560 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior .../sfml/extlibs/headers/stb_image/stb_image_write.h:1263:14 ``` I've encountered this as well. I'm using `std_image_write` version 1.16. It appears to happen when...

When trying to call `stbi_load_from_callbacks`, clang-tidy-17 warns about potential undefined behavior. We use this function when trying to encode JPEGs so this may be related to the UB we're seeing...