Chris Thrasher

Results 360 comments of Chris Thrasher

I was able to use `UniqueResource` to remove the custom destructors for `sf::Shader`, `sf::Texture`, and `sf::VertexBuffer` which means we've met my minimum requirement for this being a worthwhile addition to...

> Do we though? I reverted that decision between writing that comment and the latest commit. My new preferred solution involves no `optional`s, at least not internal to `UniqueResource`. >...

> If we require that a default-constructed handle corresponds to a null state, maybe UniqueResource needs to be in sf::priv namespace as it cannot be used in the general case?...

It's okay, @github-actions, we just need some more time to get this implemented.

I have a number of thoughts on error logging I wanted to share. - `sf::err` in its current form is part of the public API. I'd prefer to demote it...

> If we update to conan 2.0 all conan 1.X will break. I am not aware of how to maintain compatibility and think it is just the price we pay...

I'm unable to reproduce this error using CMake 3.26. Those of you who can reproduce this, what version of CMake are you using?

@vittorioromeo and I have discussed this in past PRs and we both prefer this style. I'm happy to write the commit in case we want to look at how the...