Chris Thrasher
Chris Thrasher
https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stroke-miterlimit In the graphic that shows 3 different miter sizes, the middle one is what looks more desirable to me. Is this a fundamentally different behavior or simply demonstrating a...
> We could clamp the user provided value to be at least 1. Would that deserve printing a warning to the console? I think the `assert` is good. Our API...
As the internal angle approaches zero, I'd actually expect the outline's corner point to move very far from the shape. To fix this we'd have to do something like support...
> This brings to mind SVG stroke-miterlimit attribute. See https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stroke-miterlimit I like this behavior. I'd support this feature. I'm unsure how hard it will be to implement though.
Here is where I generate docs for the sake of catching warnings: https://github.com/ChrisThrasher/argon/blob/fa7b4b75d49eefb1cbeb7bc236dbdcc14e80e407/.github/workflows/ci.yml#L132-L147 Here is where I generate docs for the sake of deploying to GitHub Pages: https://github.com/ChrisThrasher/argon/blob/fa7b4b75d49eefb1cbeb7bc236dbdcc14e80e407/.github/workflows/cd.yml#L15-L44 In our...
What would a unit test look like to catch this? Maybe we check the local bounds of "Test" then add an underline and observe that the local bounds do not...
https://github.com/SFML/SFML/compare/master...test_text The existing `sf::Text::getLocalBounds` and `sf::Text::getGlobalBounds` tests were pretty basic and not terribly useful so I wrote some more that should do a better job actually testing their logic. These...
I fixed up some minor style issues to get those out of the way early. Thanks for submitting this! I'll take a closer look when I have some more time...
Looks like clang-tidy caught something suspicious. Check out those CI logs to see if there's anything we need to fix. https://github.com/SFML/SFML/actions/runs/6343566229/job/17231737846?pr=2713#step:8:76
> If required, I can change it to something more verbose: horizontalOffset perhaps? Addressing this clang-tidy error in some way will be required. Either fix whatever it's complaining about or...