Chris Thrasher comments

Results 360 comments of


                                            Chris Thrasher

Improve `sf::Time` interoperability with `<chrono>`

Rebased and reformatted because of #2159

Improve `sf::Time` interoperability with `<chrono>`

With Bromeon's and Vittorio's approval, is there anything else we're waiting on before this is good to merge?

Improve `sf::Time` interoperability with `<chrono>`

Rebased on master, fixed a compiler warning caused by Doctest changes, and found somewhere to use this new implicit `chrono::duration`->`sf::Time` conversion to simplify code.

Improve `sf::Time` interoperability with `<chrono>`

Added a missing `&` on a parameter and rebased on master.

Improve `sf::Time` interoperability with `<chrono>`

@Bromeon would you mind checking this out?

Improve `sf::Time` interoperability with `<chrono>`

Rebased on master and added an `assert` to handle a potential edge case that could cause UB in the tests.

Clarify documentation offset behavior for sf::Text::setPosition

Can you share the font .tff you're using so we can be sure that isn't the cause of any of these issues?

Overhaul `sf::IpAddress`

I'd most prefer we just throw during construction. This is impossible for users to ignore, trivial to test, and maintains the clean constructor syntax that C++ developers expect. By returning...

Update time utilities and make sf::Clock pausable

This PR has become significantly diverged from the `master` branch. Can you rebase and squash on `master`?

Update time utilities and make sf::Clock pausable

Can you squash this into some smaller number of commits and remove the merge commits you added? That'll have to happen before it can get merged.