Chris Thrasher

> Clang with MinGW-like command-line (2.6) https://github.com/SFML/SFML/pull/1957 This PR changed how we were defining the fixed-width `sf::` integer type aliases. Sadly it uses C++11 features which makes it incompatible with...

```cmake target_compile_features(lwlog PUBLIC cxx_std_17) ``` will ensure that any targets that link to this target inherit that C++17 requirement and means you can stop manually setting target properties.

`target_compile_features` is the most modern and idiomatic solution.

Looks like the Threads package isn't being used

Finding the Threads package won't automatically add `-lpthread` to the linker line. You need to link against the `Threads::Threads` target to get that.

https://github.com/ChristianPanov/lwlog/pull/21

https://github.com/SFML/SFML/actions/runs/3047035798 Do you know why our CI pipeline may not have caught this? Simply adding `` is likely the easy fix but I want to know how we missed a...

Go ahead with the PR. It's exactly what I would have done anyways. I just hope in the meantime we can figure out how this slipped through the cracks.

Can you build the `sf::Time` unit tests? The first header in that test .cpp file is Time.hpp so if Test.hpp was missing something I'd expect that test to not compile....

@eXpl0it3r Any idea why our CI pipeline didn't already catch this? I ensure the tests include the header under test first precisely to catch these kinds of errors so I'm...