Chris Penner
Chris Penner
Looks like restricting to `fsnotify == 0.2.1.2` worked, but this should probably be restricted in the package deps. Or even better, add hylide to a stackage snapshot 😄
Hi @freizl 👋🏼 ; We'll be implementing the Auth for https://www.unison-lang.org/ 's CLI app soon and will need PKCE for that, I'd be happy to implement and add a PR...
The relative prefix matching should be pretty easy, right now the absolute pattern matching is probably easy too. If we want it to be future-proof for if we eventually stop...
Some more questions that have come up during reviews: * When will it be acceptable to stop including Absolute names when pretty-printing/parsing? Can we do it now? * Why does...
Sounds good to me 👍🏼
Hrmm, it looks like the cli-integration tests are failing to exit on windows for some reason, I wonder if it's waiting for the LSP server to shut down or something,...
PPE and Names stuff : https://github.com/unisonweb/unison/issues/3256
We should add transcripts for each of these as we find them 👍🏼 , the naming stuff is finicky and it's really easy to accidentally cause rippling changes.
For Hacktoberfest implementors: * The Docs command is handled here https://github.com/unisonweb/unison/blob/3996559579bf5a35bf885ecb4f7d5838574b027e/parser-typechecker/src/Unison/Codebase/Editor/HandleInput.hs#L1047 * You'll need to make the argument optional https://github.com/unisonweb/unison/blob/3996559579bf5a35bf885ecb4f7d5838574b027e/parser-typechecker/src/Unison/Codebase/Editor/Input.hs#L131 * And will have to adjust the arg parser https://github.com/unisonweb/unison/blob/3996559579bf5a35bf885ecb4f7d5838574b027e/parser-typechecker/src/Unison/CommandLine/InputPatterns.hs#L309-L314
I believe this issue was written before we started using fzf fuzzy-finding as a default for some commands (view, edit, cd, etc.) I wonder which is the preferable behaviour now?