ChrisMart21
ChrisMart21
It seems that docker compose is still configured to run the webpack dev server. So docker-compose up is running both vite and webpack dev servers. Notice that vite is on...
The same idea has also occured to me, and I've got some changes to admin pages undergoing tentative development that address this concept. With the migration to rtk, react-router was...
Initial maps migration has begun, and can be tracked on [mapsRTK](https://github.com/ChrisMart21/OED/tree/mapsRTK) A solution to the issue of an HTMLImageELEMENT in state has been identified, and is nolonger needed for the...
@huss is this issue still reserved? I'm currently working on many of the admin pages maps included. This rework changes how admin pages update edits locally using redux state. The...
@huss Unfortunately I've touched all admin pages quite a bit. I'm unsure if this will cause issues for the other teams, but definitely changes it quite a bit. I don't...
Have not looked too deeply into this, however some thoughts: Notice that uiSelectors.ts - -SelectUnitCompatibility https://github.com/OpenEnergyDashboard/OED/blob/development/src%2Fclient%2Fapp%2Fredux%2Fselectors%2FuiSelectors.ts#L31-L63 Calls methods from determinecompatibleunits.ts https://github.com/OpenEnergyDashboard/OED/blob/development/src%2Fclient%2Fapp%2Futils%2FdetermineCompatibleUnits.ts#L5 SelectUnitCompatibility 'depends' on unit data, but it isn't in...
There is an upcoming migration planned to upgrade Redux to Redux-Toolkit. Utilizing the middleware api we could implement tracking not unlike an example on their docs. https://redux-toolkit.js.org/api/createListenerMiddleware#standard-usage-patterns In short, an...
> * The early implementation of the unsaved warning was implemented using both React and Redux. > > * From commit [e30fb1d](https://github.com/OpenEnergyDashboard/OED/commit/e30fb1df0f9972822e05f96cddd158750bc9fdfb) to [72f111b](https://github.com/OpenEnergyDashboard/OED/commit/72f111bb271848f9df94f6fb33f3bb2b63ce50a6), the implementation of the UnsavedWarningComponent changes...
Much work was done to maintain serializable state, and to be able to safely enable the serializable dev check. I think it would be a step back, & in the...
state.ts was the older pre-rtk way of defining the shape of state. With rtk state is now inferred a bit differently. State.ts was kept for compatibility reasons, and should phased...