Christopher Jefferson
Christopher Jefferson
As I understand it, the issue isn't anything to do with libgap, or GAP at all. It's all about longjmp, and the following text from longjmp's docs. We could write...
will do, once it gets up my list to the top again :)
@dimpase : In general, it is very, very common for GAP to have different functions for when it knows the size of a group (look for `HasSize`). Usually these algorithms...
I think I've made the required tweaks, but if it's not right, I'm happy for someone to just chuck this / write their own, which I realise might be quicker...
No, looks good!
My initial comment is maybe add some tests? I'm guessing you understand the types of groups you need to hit the various cases in the algorithm, and make sure it...
I have some small comments, but I'd say the BIG missing thing is tests, lots of tests! As a suggestion, you could base you tests on something like this: ```...
I don't think this test ever executes the code from line 76 onwards
There is no documentation at the moment. I think in this case (but I might be wrong, feel free to comment!) this probably shouldn't be used by default for MinimalGeneratingSet,...
I like this functionality, I wouldn't mind a name change, but nothing else is required. However, I would personally perfer OccupiedError be changed from: ``` pub struct OccupiedError, /// The...