Christopher Jefferson
Christopher Jefferson
The following issue might not need dealing with for the initial commit, but I thought I'd raise it anyway. I'm a bit confused about `transform` vs `image`. Are they just...
While I actually agree with this patch in principle, I would hope it would wait until a major release, as it's going to break every piece of code using gason!
Just to say, I'm just a random guy who read and commented on your patch, not @vivkin :)
There is far too many things here (in my opinion) dumped into one patch, and you have changed the formatting of every line of code. It doesn't seem possible to...
Other issues: at() / operator[] return a null if the object being dereferences is not an array, or for out-of-bounds. It seems more 'gason' to assert if we try to...
The main problem with the whitespace changes is that is makes it very difficult to see what changes you have made, as when I run the code through a differ...
I can understand not wanting to pretty print the comments -- I was suggesting throwing them away entirely. For my current use, I have written a "strip comments" function I...
Do you have a full program (not sure how to make `D`?) If so, I could try running it through GAP with valgrind, and see if it more accurately points...
This is probably easier to do by adapting IsIsomorphicDigraph -- it almost calculates this, just change the last line so, once you have checked if the graphs are Isomorphic, return...
I will look at the other solver. It might be worth adding "subgraph isomorphism" to the index in the help, I was looking in GAP packages for subgraph isomorphism, and...