Chris Hegarty

Results 113 comments of Chris Hegarty

Just to expand a little on a previous comment I made above. > Could Lucene ever have this directly in one of its modules? An alternative option to putting this...

> One thing the Scorer object gave us is caching of the single vector that is used many times. > > The underlying Offheap vector objects cache the vector on...

Loopy testing runs without issue for 100+ times ( I just stopped it at that point ). ``` $ export x=; while ./gradlew :lucene:core:test ; do echo $x | wc...

> Cool. Seems useful to achieve the goal. > > As written in the original issue maybe we should disallow clones, random access and slices of IndexInput on top of...

loopy testing with `-Ptests.directory=MMapDirectory` all successfully after several dozen runs.

>Merging uses an IOContext with a MergeInfo attached. This uses same ReadAdvice SEQUENTIAL, but that is different to the Singleton READONCE IOContext. Or do I miss something? I see same...

I updated clone and slice. It finds some issues. These look like incorrect usage of READONCE.

... there's still some intermittent failures because of this. I'll track them down so that we can discuss.

Thanks for the comments so far. I updated the PR to only check same-thread semantics for MSII clone and slice. And also added some basic thread checks to MockIndexInputWrapper. I...

> Regardless that its already much slower for the int4 case on both jdk 21 & 22. @benwtrent I was not aware, lemme take a look.