Chris Hegarty comments

Results 113 comments of


                                            Chris Hegarty

Remove vector values copy() methods, moving IndexInput.clone() and temp storage into lower-level interfaces

> [the last commit](https://github.com/apache/lucene/pull/13872/commits/ef13bade9b3ab8eb5de35e7297a9468ec45fc745) demonstrates re-using the resource-intensive bits (RandomVectorScorer and Floats) for the floarting point case. It brings back heap allocations to be similar to what we see on...

Use SPI instead of Enum for VectorSimilarityFunctions

> The main motivation behind this change was to get rid of ENUM implementation which is tightly coupled to field-info. This has caused inconvenience in deprecating the COSINE function from...

Upgrade the Elasticsearch version

At time of writing, the most recent version is: https://artifacts.elastic.co/downloads/elasticsearch/elasticsearch-9.0.2-linux-x86_64.tar.gz Care should be taken in the docker file when customising the JVM options, since replacing it may drastically affect how...

Unmute #111529

Minimally, some scenarios still fail: ``` SearchServiceTests > testWaitOnRefreshTimeout FAILED junit.framework.AssertionFailedError: Unexpected exception type, expected ElasticsearchTimeoutException but got org.elasticsearch.search.query.SearchTimeoutException: Wait for seq_no [0] refreshed timed out [87ms] at __randomizedtesting.SeedInfo.seed([7AC555CCB6E2E0F7:CBFD9EFA3DB5002F]:0) at...

Replace need for KnnVectorValues.copy() with a dictionary interface

Unless I'm mistaken, then `KnnVectorValues` and friends are "lucene.experimental" APIs. So, while maybe a little annoying, can be changed in a future 10.x release. No need to wait for a...

Add mixed mode BWC testing support for test-specific plugins

> [@ChrisHegarty](https://github.com/ChrisHegarty) do you have a branch/open PR I can pull to repro the error locally? This commit enables multi-versioning testing in ES|QL, so reproduces the issue: https://github.com/ChrisHegarty/elasticsearch/commit/82a638183e9ae737ea04744f9203a95862e0bb50 Then just...

Fix and unmute VectorSystemPropertyTests

The test now fails with: ``` > Task :libs:native:test VectorSystemPropertyTests > testSystemPropertyDisabled FAILED java.io.IOException: Cannot run program "C:\Users\buildkite\.gradle\jdks\oracle_corporation-22-amd64-windows.2\bin\java": CreateProcess error=1816, Not enough quota is available to process this command at...