Chris Dryden
Chris Dryden
I'm curious on your take with the cleaning up of the readability of the tests? I'm finding that theres a mismatch of integration test styles in every folder and that...
Am so glad that we now have the integ tests running on the CI for this binary, it spotted a bunch of stuff.
Moved the libc to a helper function with comments and added some comments to the main wrapped printer class
The only errors are coming from this PR: https://github.com/uutils/coreutils/pull/9471
@sylvestre mind if I get a second review on this one?
Good idea, I added a helper in the parser folder to be able to reuse that logic
The benchmark change is unrelated, should be good for another round of reviews
I ended up reverting back to the approach of using the existing parsing helper function since it reduces the amount of new code, and IMO makes it cleaner. Now that...
Hmm an issue with one of the baud rate integration tests came up, was covered up by the seq failure before
Darn so it used to be back before 9.2 that it would except invalid arguments without failing?