coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

Stty: Implemented input and output baud rate setting for stty

Open ChrisDryden opened this issue 1 month ago • 10 comments

There's two other open stty PR's: https://github.com/uutils/coreutils/pull/9490 and https://github.com/uutils/coreutils/pull/9516 . Once those two are merged all of the stty tests pass except for the bad-speed test. This test overrides cfsetispeed and checks to see if it is called. Currently our implementation of stty only overrides the cfsetospeed. The support to do both in GNU existed for a while. I changed the enum and parser to treat the ispeed and ospeed seperately and I added integration tests that compare that using those new flags matches the input and output of the GNU implementation.

ChrisDryden avatar Nov 28 '25 22:11 ChrisDryden

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Nov 28 '25 22:11 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar Nov 29 '25 04:11 github-actions[bot]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Dec 02 '25 16:12 github-actions[bot]

Hmm an issue with one of the baud rate integration tests came up, was covered up by the seq failure before

ChrisDryden avatar Dec 02 '25 16:12 ChrisDryden

Darn so it used to be back before 9.2 that it would except invalid arguments without failing?

ChrisDryden avatar Dec 03 '25 05:12 ChrisDryden

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar Dec 03 '25 05:12 github-actions[bot]

CodSpeed Performance Report

Merging #9517 will not alter performance

Comparing ChrisDryden:stty_input_and_output_speed (970fef3) with main (2000af8)

Summary

✅ 127 untouched
⏩ 6 skipped[^skipped]

[^skipped]: 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

codspeed-hq[bot] avatar Dec 03 '25 05:12 codspeed-hq[bot]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Dec 07 '25 18:12 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar Dec 07 '25 19:12 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/stty/bad-speed is now passing!

github-actions[bot] avatar Dec 07 '25 21:12 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/stty/bad-speed is now passing!

github-actions[bot] avatar Dec 17 '25 16:12 github-actions[bot]