Christian Bernasconi

Results 3 comments of Christian Bernasconi

I also had to retarget the solution and update to SDK 142 and to enable the -G feature I had to change a couple of files: - https://github.com/ChrisBerna/kcat/commit/2056092b10064153f50d75d2cfda1d22d85e2822

> Shouldn't we add at least a unit test somewhere ensuring the GroupId is set? You're absolutely right, I added some unit tests here: https://github.com/BEagle1984/silverback/blob/fa38eb8ef7de7181003ac5efdf2b6bba42be1cb9/tests/Silverback.Integration.Kafka.Tests/Messaging/Configuration/Kafka/KafkaConsumerConfigTests.cs#L31 https://github.com/BEagle1984/silverback/blob/fa38eb8ef7de7181003ac5efdf2b6bba42be1cb9/tests/Silverback.Integration.Kafka.Tests/Messaging/KafkaConsumerEndpointTests.cs#L152 https://github.com/BEagle1984/silverback/blob/fa38eb8ef7de7181003ac5efdf2b6bba42be1cb9/tests/Silverback.Integration.Kafka.Tests/Messaging/KafkaConsumerEndpointTests.cs#L163 I wanted also...

> * Still no test that ensures that no commit is performed when the group id is not set? > * By the way, the mock is behaving correctly already,...