Christopher Marshall

Results 8 comments of Christopher Marshall

I've taken a deep look into this and I don't believe it's something that is going to be easily fixed. It's certainly beyond my ability to fix, I've been at...

It depends really on whether there is any arbitrary HTML put into the trans tag in the template..... it is possible for a template designer for instance to accidently add...

Ok: GREAT news. I've managed to get a working version of this. It's not perfect and for my own purposes I had to completely rewrite the plugin, so I'll only...

A note though that this will add the raw tag on for ANY filter, not just when you add "|raw". For some reason it still can't pick up filters so...

Sorry I've just seen this. Do you still need a PR?

Just realised I uploaded my solution to Github here: https://github.com/Chris98/TwigI18nExtension I'm afraid I don't have the time to do a proper PR, but my full solution is here which you...

> I think we should deprecated the usage of tags, introduce a `trans` function, and use only the function and the filter. The tag does not respect the auto-escaping because...

To fix it, you want to change the `checkTransString` function in `TransTokenParser` to something like this: ```php protected function checkTransString(\Twig\Node\Node $body, int $lineno) { foreach ($body as $i => $node)...