Zhiwei Liang comments

Results 64 comments of


                                            Zhiwei Liang

(websockets 12.0) DeprecationWarning: websockets.connection was renamed to websockets.protocol and Connection was renamed to Protocol

@Tronic You are right, lol. I will try that way.

Python 2.7 => 3.X

Thank you for your response. I think everything is clear and I hope I may see the guide soon. Thanks for your work!

Raising a 412 on a Sanic handler causes a wait period and maybe a ReadTimeout exception on clients

Hi @ahopkins, FYI: content-length was removed for 412 responses since https://github.com/sanic-org/sanic/pull/1127 Other than the PR description itself, there was not much discussion about the header removal for 412 responses, nor...

Raising a 412 on a Sanic handler causes a wait period and maybe a ReadTimeout exception on clients

Fixed in https://github.com/sanic-org/sanic/pull/2824 and https://github.com/sanic-org/sanic/pull/2962.

Using blueprint.copy leads to warns about duplicate routes

@ahopkins I think this is about how the sanic router detect and (will) remove duplicated routes (enforce uniqueness). For the issue #2554, after some minimal modifications, sanic can let the...

Validation with Dataclasses| About Optional[str] and None

I confirm this issue is reproduceable. If no one else had started working on this, I will look into it. But this looks like a [sanic extension issue](https://github.com/sanic-org/sanic-ext/issues).

Validation with Dataclasses| About Optional[str] and None

@sanic-org/sanic-release-managers Can we transfer this issue to [`sanic-ext` repo](https://github.com/sanic-org/sanic-ext)?

Enforce unique route names

Was this added in 23.3?

[python-socketio (websocket transport)] sanic.exceptions.ServerError: Invalid response type None (need HTTPResponse) on Disconnect

I couldn't reproduce the issue with latest Sanic (`main` branch), latest `python-socketio` (`5.11.2`), and Python 3.11 on Linux.