Zhiwei Liang
Zhiwei Liang
> It would probably make sense for us to just always add all new imports inside an `if TYPE_CHECKING` block, right? By definition they are typecheck-only imports. That would solve...
I made Cognito send verification link on AWS Online Console but Amplify in my ReactJS is still asking users for verification code after signing up email sent, and way to...
Love this feature. Wish to see it in dotnet in the future.
This has been solved in the previous PRs. Feel free to reopen if there is still an issue. Tested and is no longer reproducible.
@ahopkins This seems simple and approved? Can we make it ready and rerun the CI? I think the main branch would also need it.
@ahopkins I am not familiar with the URL APIs in Sanic but this sounds like `urllib.parse`? This PR seems like simple fix to an issue related to the feature that...
@SaidBySolo I think you are right. Can't reproduce with sanic-22.9.1 and Windows 11. But the issue is existed in the 21.12LTS.
Is this issue considered as solved?
How is the status of this issue? Are we still going to work on it? We want: 1. Handle the trailing slashes issue. 2. Add the `fallback` option. right?
@Tronic @ahopkins Just tested, and the trailing slashes is no longer reproducible in the latest code base. `resource_type` is also checked here and in the following lines, https://github.com/sanic-org/sanic/blob/4422d0c34d7a5652395de49e3a5db42457245ff0/sanic/mixins/routes.py#L957 So, I...