maqianlie

Results 5 comments of maqianlie

谢谢~我编译的时候出现error,我先看看能不能自己改,不能的话给你报上来。另外网页版有bug。我另开issue

新年快乐~~ : D 打搅你工作了,下面是错误信息: ``` bash :build ChienliMa$ make [ 20%] Building CXX object CMakeFiles/find_armor.dir/find_armor.cc.o In file included from /Users/ChienliMa/Code/monster-avengers/cpp/find_armor.cc:1: In file included from /Users/ChienliMa/Code/monster-avengers/cpp/./monster_hunter_data.h:11: /Users/ChienliMa/Code/monster-avengers/cpp/./helpers.h:90:5: error: use of undeclared...

Is there something else need to be done besides changing its name? Like documentation.( Well, i'll make a PR later )

Hi, I am new here. Do you mean something like this? Should the test case also be changed to cover the code?

Sorry for my disappearance. @kmike for you opinions: ##### what happens if idled returned nothing? If users implement the idled() and return nothing, or something other than a generator, nothing...