Cheuk Ting Ho comments

Results 100 comments of


                                            Cheuk Ting Ho

[Feature request] Directly expose tp_bases, tp_mro, and tp_subclasses on PyType in high-level API

According to this (https://docs.python.org/3/c-api/typeobj.html#c.PyTypeObject.tp_subclasses) seems `tp_subclasses` is for internal use only. Maybe we should work on `__bases__` and `__mro__` first.

RFC: rename `PyString` -> `PyStr`, and `PyLong` -> `PyInt`

@davidhewitt is this issue ready to be closed? Seems the PR has been merged

RFC: rename `PyString` -> `PyStr`, and `PyLong` -> `PyInt`

I see, I am happy to work on deprecating the `PyUnicode` alias, do we need to produce a warning or what's the plan for deprecating it other than removing it...

Collecting multiple attribute error

Thanks for the suggestions @davidhewitt i have added the test and have refactored as suggested.

Collecting multiple attribute error

Thank you for your patience. I was busy with EuroPython. I plan to finish this PR this weekend or next week.

Collecting multiple attribute error

Thank you @davidhewitt

Contribution opportunity: use Python 3.12 managed dict and weakref

May I have a look into this?

Seal some traits inside impl_ submodule

I will have a look again at this, I think we can seal more traits. Will ask for a review again when it is ready.

Seal some traits inside impl_ submodule

@davidhewitt I have tried sealing most of the traits in `pyclass.rs` and it seems more complicated than what I did before (involving some macro as well). Do you want to...

Seal some traits inside impl_ submodule

@davidhewitt since it has been a while, shall I rebase and wrap it up, so that this can be merged? We can come back to finish off this issue later...