Seal some traits inside impl_ submodule

Open Cheukting opened this issue 1 year ago • 2 comments

Attempt to close #3908

First, I try sealing PyAddToModule to see if I am getting in the right direction
@davidhewitt Please kindly review
If it is correct I can try working on more of the traits

Jul 20 '24 17:07 Cheukting

I will have a look again at this, I think we can seal more traits. Will ask for a review again when it is ready.

Jul 21 '24 14:07 Cheukting

@davidhewitt I have tried sealing most of the traits in pyclass.rs and it seems more complicated than what I did before (involving some macro as well). Do you want to have a look before I move on to other files in impl_? This seems like a big PR with lots of changes.

Jul 29 '24 18:07 Cheukting

@davidhewitt since it has been a while, shall I rebase and wrap it up, so that this can be merged? We can come back to finish off this issue later I think

Sep 20 '24 08:09 Cheukting

@Icxolu after rebasing it seems a bit too messy to continue with this PR, I have opened #4606 to wrap it up with sealing PyAddToModule. The sealing of traits in pyclass seems to need another visit.

Oct 09 '24 11:10 Cheukting