Cheng Li

> This is a review of just local behaviour. > > Thoughts on overall design I'll do probably later but my thoughts is that this is a leaky abstraction and...

Hello, I can see a lot of reviews are about the comments on the code, which I did not pay much attention to. I am fixing those now. Thanks for...

> If I'm not mistaken... this is what I was saying was bad? You'd written a state machine inside the future, rather than using the syntax sugar of `async fn`....

> called `Result::unwrap()` on an `Err` value: ClangDiagnostic("error: version 'minimal' in target triple 'aarch64-sel4-microkit-minimal' is invalid\n") Hi, Ivan. It looks like the build script of sel4 crate pass target 'aarch64-sel4-microkit-minimal'...

> When it would make more sense for > > ```rust > // these don't /really/ need to be async, but if you need to send CMD5 for APP_CMDs before.....

> Personally, I think whether the future is designed in your proposed way or my way is more like a design choice and does not have much influence on performance...

> This is the whole point, to make a good design? (Which then should be performant and correct). There are a lot of ways to do things badly that can...

For sdcard driver, the protocol requires the driver to DMA some information to normal memory region and parse the information by the driver.

> Hi， I have also encountered a similar problem. Have you found the cause? Hello, could you give me more context for this problem? Like how do I replicate this...

> Same comment as previous: is there a design written up for this that we can look at? Writing the doc now. Should be available soon.