CharlieSears
CharlieSears
@devGregA sorry for the late reply. I'll get this up to snuff and a merge prepped. I don't believe I'll have it ready for 2.16.0 given how close that is.
~I added translations since the initial state of this branch is so old. However there are massive changes in the en django.po file. I'm happy to revert those changes or...
Happy with the functionality at this point. Going to get some tests thrown together and turn this into a proper PR from draft.
> @CharlieSears just looked through everything since it was marked as ready and all looks great! No changes from me :) I see you've got some empty checkboxes for unit/integration...
Added integration tests, removed unit test task due to minimal business logic which is fully covered by integration tests. Happy to add them if yall see fit.
Going for longest lived branch here but I'm sure I'm not even close 😆 Thank you all for your patience and interest. Excited to get this in and in use.
> Besides my two suggested changes above, everything else looks great! Thank you! Not sure how I missed the internationalization tag, added both your suggestions and ~testing locally now with...
@Maffooch / @blakeaowens , are either of you able to re-run tests? Integration tests are passing locally, but getting intermittent failures on test_test and findings_test in the actions. A re-run...