Charity Kathure
Charity Kathure
- [x] Merge master into windows-containerd-as-proces - [x] Resolve Merge conflicts - [x] factor out the common Linux code into a (partially) shared implementation - [ ] Address failing checks
Containerd issue resolved by this PR: https://github.com/containerd/containerd/pull/9118. cc @iankingori @brwilkinson
cc: @olljanat , @cpuguy83, @thaJeztah
@thaJeztah, please approve the GitHub Action workflows.
// gRPC issues have been resolved for this task. Tagging @thaJeztah, @olljanat, and @TBBle for review and input.
> @CharityKathure Thanks! ❤️ Could you please also rebase your PR on top of master to avoid merge commits (and possibly squash commits)? @vvoland The PR is updated now.
@easwars Thanks for the response. The primary goal of this PR is to ensure proper handling of Windows named pipes (npipe) in the `parseDialTarget` function. **The use case:** When Docker...
@easwars In this context, Docker starts containerd, and a new client connection to containerd is established using gRPC. The client is configured to connect to an address (`r.GRPC.Address`), which is...
@vvoland, I can not repro the `TestCopyFromContainerPathIsNotDir` failure. I am getting the expeted error message: 
Deleting the `Docker` folder in `C:\ProgramData` resolved this issue for me on Docker Desktop 4.39.0. I didn't need to downgrade or reinstall Docker.