ChanceNCounter
ChanceNCounter
Suggest migrating this to Lingua Franca and editing to reflect the parts Jarbas has fixed, unless "yesterday" is regarded as critical enough to warrant porting that fix back here.
It's tricky. I agree with Jarbas 100% that it should return the last number, and I agree as to why. I'm also unafraid of breaking changes in a module that's...
Well, putting it back has my approval, but I do think we should run a test branch against downstream for a week or two before we merge the change, just...
@ChristopherRogers1991 I'm driving by, so haven't had a lot of time to consider your input, but I will - wanna make sure you know your opinion matters a *lot*. One...
On reflection, I think left-to-right as the conventional thing makes sense. I've also just checked `extract_datetime`, and it goes right-to-left. That's an internal inconsistency to think about. That function's scheduled...
fwiw, re: new and/or less skilled developers, the flip side of parsing utterances the way we think users expect is that inconsistency with other libs. Inconsistency between libs is *also*...
💯 i like it. the sugar is unambiguous, the existing function signature returns the same thing it's been returning for ages, and both results are easy to find.
found bug: multiple instances of "point" or "dot" in the input string confuse the parser.
The status box on this PR seems to be broken. If I click on Travis, it shows all the builds completed successfully.
(rfc @krisgesling @forslund @JarbasAl)