ChanceNCounter

Results 215 comments of ChanceNCounter

@JarbasAl I seem to recall that you were working on `extract_number()`. Will you be covering this in that round?

Yep. TZ PR broke it. I wonder why the tests passed on GitHub. It's not just Farsi, either.

Update: Jarbas and I are on it. At least two of these are due to a loss in translation during PR review. Others were masked by naming errors in the...

Working in spurts, I have yet to determine why the default time zone seems to be changing mid-run. However, many of the datetime tests specify the default time zone when...

For example, `extract_datetime('2 wochen')` and `extract_datetime(2 tage)` both fail in the absence of an explicitly-passed anchor date. These calls passed in LF 0.2.3, and the change didn't make any tests...

Agreed. I think some/most of this still involves those JSON parsers, so it'll be more than a five-minute fix. Take a stab, if you like; if not, I'll throw it...

PR MycroftAI/mycroft-core#2356 does _not_ fix any of these issues, but it _does_ modify these files, so anybody else who might touch these bugs might note whether it's been merged.

I think this can be addressed without much of a performance hit by way of rolling token replacement. The alternative, iterating over the original and replacing only the chunks where...

Thanks to [this](https://community.mycroft.ai/t/day-identification-is-not-working-correctly/7419/4) forum post by user tiredoftry for discovering this via asking about the weather