Cfretz244

Results 9 comments of Cfretz244

Oh yeah, it would be great if it could tap into the existing logging. Personally, I've never been a big fan of libraries logging in the first place, but there...

Hey Hrishikesh! I've thought about adding simdjson integration in the past, my primary hesitation with it has just been that it's not actually a conformant json parser.

In my understanding, simdjson uses SIMD instructions to compute a bitmap of "structural elements" (characters like commas, curly braces, double quotes, etc) in the incoming string, which it then iterates...

It can definitely parse anything that _is_ actually JSON, but it'll _also_ parse a large set of documents that definitely are _not_ JSON. The effective grammar is _much_ looser

That being said, we could add it and just document the fact that it shouldn't be used if the input string isn't from a trusted source

The additional problem is that I'm not sure what kind of performance improvement we'll see, because after simdjson runs, Dart still needs to construct its representation of the document parsed...

Until then, if you install sajson and build with the `-DDART_USE_SAJSON` flag, you should see about a 2x improvement in parsing performance by just using sajson. sajson strikes a really...

Note that this switch to sajson will only significantly affect parsing performance when parsing in finalized mode So code like the following: ```c++ auto pkt = dart::packet::from_json(R"({"hello":"world"})", true); auto buf...

Just wanted to update here that I was apparently incorrect about the conformance bit with simdjson. I last looked at the project like 9 months ago and it's come quite...