Casper Welzel Andersen

Results 80 comments of Casper Welzel Andersen

Ah yeah, I see. So maybe we should simply point the default config file path to `tests/test_config.json`? Or have the `example_config.json` be valid, in terms of our server's aliases and...

Hmm, I'd honestly prefer the example server to be as gritty as possible - as close to real life as possible. And since most providers will come with their own...

Thinking more about this, I think we should instead keep the repo as it is now, but instead set an environment variable in Heroku to locate the desired config file...

> @CasperWA @ml-evs @shyamd Gentlemen, are any other relevant changes required? If not, please could you prepare a release? I've been busy with an OPTIMADE client, and hence have not...

> I will try to find time to look back into this issue this week. Great! > What is the consensus now concerning the hoster for the demo server -...

Sounds intriguing. I am having a bit of trouble wrapping my head around how this would be done, could you perhaps roughly outline a diagram or explicit example?

> I am not sure. I think it is different. #520 is about a proxied app that gets a different request url from the proxy than from "outside". This PR...

I've added a `root_path` to the test configuration file that's loaded for pytests. I think this uncovers an issue with the implementation, specifically concerning the middleware. This might be similar...

@markus1978 is the expected behaviour that the `root_path` is added twice to the URL path as seen [here](https://github.com/Materials-Consortia/optimade-python-tools/pull/663/checks?check_run_id=2065765962#step:6:536)?