Carson Full comments

Results 95 comments of


                                            Carson Full

fix(graphql): readonly arrays not allowed in decorator input

> minor changes to support both array and read only arrays These represent the same thing. Mutable arrays are a superset of read-only ones. But if this style is preferred...

fix(graphql): avoid partial field declarations from inherited metadata with cli plugin

Bump 🙏

feat(client): specify headers for individual subscribe calls

I personally do not like an `extra` prop, it feels hacky and has to be extracted before the JSON is serialized. What about a second argument? A generic `context` argument,...

feat(client): specify headers for individual subscribe calls

Ah I'm seeing now there are multiple arguments already. Specifically the optional event listener arg. I should've finished my coffee ☕️ Perhaps another is still ok?

feat(client): specify headers for individual subscribe calls

I updated the Apollo recipe in #124 to include a workaround to allow this.

Shape with pointer of `false` produces type suggesting the pointer is returned

Could we change the arg shape to reject `false`? https://github.com/edgedb/edgedb-js/blob/0bf404ec6e3479379417b234e0500e2f4b76310d/packages/generate/src/syntax/select.ts#L755-L755 ```ts | true ```

[Docs] Docker - SERVER_JWS_KEY

It is there now as `SERVER_JWS_KEY_FILE`. I think it would be nice if followed suit with ``` GEL_SERVER_PORT / _FILE / _ENV ```

feat: Add safe Yarn PnP support

Thank you for the patch @bmulholland this worked for me too. Hopefully this can get merged/released.

Optimize default isolation/readonly serialization

I figured you knew. Just didn't want to lose it. I know you are wearing 10 hats 🙂

Optimize default isolation/readonly serialization

Another wrench: annotations. They contribute to the options identity but are serialized/encoded/sent separate from the class. https://github.com/geldata/gel-js/blob/master/packages/gel/src/baseConn.ts#L496-L503