protractor-styleguide

protractor-styleguide copied to clipboard

Rule-17 examples inversed?

2

rule 17 says: `Declare functions for operations that require more that one step` but the avoid examples has such function, and recomended makes the step directly with additional complexity. so...

yadimon

set global variables in a file - not in conf file

3

currently global variables are being set in onPrepare: function () { global.myFirstVar = 1; }, I have about 30 variables, and the conf file it's starting to get a bit...

fabbsc

conditional cases

2

I believe that we can have a look over this. It seems like a generally rule of thumb. http://howtoprogram.eu/question/angularjs-protractor-protractor-jasmine-conditional-test-cases,4391

fabianclain

add live-server add style for repeat example adjust protractor.conf.js for live-server

michielreyers

Add Jasmine best practices section

1

CarmenPopoviciu

Rule-15 missing recommended example

1

I have problems understanding [Rule-15](https://github.com/CarmenPopoviciu/protractor-styleguide#rule-15-require-and-instantiate-all-the-modules-at-the-top) and it's missing recommended example. Can you please add one? From my understanding current "Avoid" example is what described as recommended.

Paragonid

The Why is emphasizing, rather, exposing the reasoning leading to a benefit whereas this point doesn't seem provide a gain, per se. Depends on your perspective, though.

roosuocha

Enforcing style guide rules

3

I've recently started to work on [`eslint-plugin-protractor`](https://github.com/alecxe/eslint-plugin-protractor) ESLint plugin designed to catch common Protractor-specific errors/violations statically. Two things: - if it makes sense, consider mentioning the plugin in the guide...

alecxe

Sugar Step for E2E Testing and Test Tags for Mocked E2E

1

Hi, i have to proposal for this guideline i would like to discuss about it so we can see if i should make a pull request. **Sugar-Step** Adding a [sugar-step](https://github.com/ldegen/sugar-step)...

thematho

I'm currently using the Gruntfile provided by the Yeoman generator, but looking at all the tasks in there, I think it is overly complicated for what this project needs. I...

CarmenPopoviciu