Rule-17 examples inversed?

[yadimon]

rule 17 says: Declare functions for operations that require more that one step but the avoid examples has such function, and recomended makes the step directly with additional complexity.

so avoid and recomended should be switched

[CarmenPopoviciu]

The rule says Declare functions for operations that require more that one step. In that example, the function contained just one step, thus making it redundant to add an extra wrapper function. I don't see how the example was incorrect.

Withe these changes, the recommended example goes against the statement of the rule

[yadimon]

One line may be more then 1 step. user.name.sendKeys('TeddyB'); means select name field, and send keys parameter its like 2 steps. For example if the logic : input name, will be more complex (name in form is not a good example, but let say is will be more complex somehow), you will need to change all places where you used this 'double step' line. With a special function for the logic its just a function content change.

btw. the function enterName should return the statement, in case the user of such function want to use promises etc.

and even if my PR were wrong, then the rule description should be like dont use function for one line code. Because it is what the code shows. Use function for more than one step is not represented in the example. So its probably just inverted and my PR is right :)