Carlos Fernández

Results 16 comments of Carlos Fernández

I will take this issue. I believe @Phlasse approach seems to be the way to go, as it keeps things sompler.

@vblagoje then what are you suggesting? We keep the `keep_id` flag, and we add a `id_generator` where the id generator can overwrite the resulting id of the cleaned document receiving...

@vblagoje Okey. I will create a new pull request, to clean the commit tree. Should I create a Class for this kind of function, to make the code more readable...

@vblagoje Opened a new pull request that contains the new implementation.

Have the same problem,

This is my first issue, I will try add this feature, but don't know if I will manage to. :)

Wouldn't it be nicer just to add a new component that crops context to the amount of tokens needed depending on how you want to do it, defeating docs or...

> > One other (small) issue I forsee when using a separate component is that it's not easily possible to know how much you should truncate the documents by. To...