Oliver Medhurst comments

Results 110 comments of


                                            Oliver Medhurst

Custom titlebar support

Looks interesting, didn't know that existed for PWAs. Hopefully possible easily via CDP.

Use user-preferred browser by default

Would be cool, currently is just in order of most preferred/usable by Gluon. Would likely use reg.exe directly to avoid external dependencies.

Use user-preferred browser by default

I meant having a dependency at all, as you can make a wrapper for reg.exe in ~5 lines

Use user-preferred browser by default

Oh, apologies. Code looks good and understandable, using a custom wrapper allows using promises as well so lol.

Use user-preferred browser by default

Possibly could be an easier idea to use file associations like .html instead. Dedicated command line tool for it on Windows so would be much simpler but unsure if some...

Use user-preferred browser by default

Yeah changed my mind, have an almost complete implementation which I'm leaving for 0.10.0, 0.9.0 should be releasing today with some new APIs.

feat: add startup config for different paths on Windows

Thanks for the PR! Could you use an array instead of new/different keys (see the Linux paths)?

feat: add startup config for different paths on Windows

Closing as Windows paths have been rewritten internally which includes local appdata path generation, and more.

feat: use simpler env vars for win32

Fixed formatting to be like the rest of the repo.

feat: use simpler env vars for win32

Updated to return `'arm64'` on such systems now too.