gluon icon indicating copy to clipboard operation
gluon copied to clipboard

feat: add startup config for different paths on Windows

Open Dustin-Jiang opened this issue 3 years ago • 1 comments

What is changed

  • Add Firefox Developer Edition startup path on Windows
  • Add paths for browsers (including Firefox, Chrome and their versions) installed for current user in AppData folder

Why

  • Firefox has multiple minor versions besides Nightly and Release, for example, Firefox Developer Edition and Firefox Beta. So it is necessary to add those particular startup paths to allow users with only one of those minor versions installed to use it.
  • On Windows, if user clicked 'Cancel' when the UAC window popped up on installation, Firefox and Chrome would be installed as for current user only, under %LOCALAPPDATA%. So I think we should search those paths as well.

Dustin-Jiang avatar Jan 03 '23 07:01 Dustin-Jiang

Thanks for the PR! Could you use an array instead of new/different keys (see the Linux paths)?

CanadaHonk avatar Jan 03 '23 07:01 CanadaHonk

Closing as Windows paths have been rewritten internally which includes local appdata path generation, and more.

CanadaHonk avatar Jan 05 '23 13:01 CanadaHonk