Stephen Page

Results 48 issues of Stephen Page

…with main site (cached) settings. [TEC-3738] [TEC-3738]: https://theeventscalendar.atlassian.net/browse/TEC-3738?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

code review

This allows checking the event against the current time easily via `$event->is_now` to allow for things like this filter: https://d.pr/i/C0QXFH https://d.pr/i/QnmxPP This is from a conversation in Slack: https://lw.slack.com/archives/C01SYM19N7K/p1660147997503949

needs ticket
code review
innovation

[TEC-4445] In a few places where we reference `--tec-color-text-secondary-event-date` (as defined in [common styles](https://github.com/the-events-calendar/tribe-common-styles/blob/main/variables/_colors.pcss#L17)) we transposed the name into `--tec-color-text-event-date-secondary` - which is not defined anywhere. Related: https://github.com/the-events-calendar/events-pro/pull/2033 [TEC-4445]: https://theeventscalendar.atlassian.net/browse/TEC-4445?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

code review

Note this is based off of B22.remonce - but is not expected to go in it. We'll have to change the base branch when we o release it. https://d.pr/v/zsouqt [TEC-3962]...

code review

This currently hooks into the view templates, determines if it is on a "single" template (for a composite view) and tells the template to not display if the user can't...

needs ticket
code review
innovation

From a Slack conversation: https://lw.slack.com/archives/C01T0TSD4SC/p1659734059492149 This takes the logic that was cluttering up the `src/views/v2/month/calendar-body/day.php` template and moves it to a function alongside the similar one we use for multiday...

needs ticket
code review
innovation

This checks the document for `lang` and `rtl` attributes and passes them on to the datepicker (because, why would it do that check itself? :P ) It also tweaks the...

needs ticket
hold
innovation

[TEC-4450] [TEC-4450]: https://theeventscalendar.atlassian.net/browse/TEC-4450?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

code review

**No longer in strudel! This is getting punted to the next MR to implement Luca's suggestions. Don't merge until the base branch has been changed!** The problem: Events created in...

code review

test to see how the GitHub actions handle it...