Cameron T Ellis

Results 9 comments of Cameron T Ellis

@yidawang are you able to look at this?

Hi Mihai, I encouraged Brynn, a student in the class, to reach out to you for this 'extra credit' exercise she tried. It turns out that these issues were related...

Hi James, Nice to hear from you again. This is a great suggestion that I will hopefully get to by the end of the week. Best, Cameron

Hi James, I have looked at your solution and I actually think that is a good one. You mentioned that refactoring the temporal noise generators might be better but I...

I agree that the default should be the lexicographic ordering (especially since we don't want to change the behavior for other users). I think adding a natural sorting step would...

Hello! From my understanding, you diagnosed the problem correctly: `assert np.allclose(voxel_iscs, voxel_iscs.T)` won't work if there are nans, so using `np.nan_to_num` 'fixed' that issue; however, it ran overnight and didn't...

@snastase I agree with your suggested fix, it seems like that assertion is unnecessary given the other checks.

@mihaic @davidt0x Is this PR waiting for review or is there still more to do?

@mihaic I will review it in a few days so that once the conda build is working the PR is ready to go.