Vincenzo Calligaro
Vincenzo Calligaro
@luzpaz, @Syres916, @maxwxyz, I think I found out why on LS3 @marbocub's files update correctly. The following code is missing in `GeoFeature::updateElementReference()` on main: ```c++ auto version = getElementMapVersion(prop); if(_ElementMapVersion.getStrValue().empty())...
@luzpaz, @Syres916, @maxwxyz after quite some fighting I think I found how to fix this issue. There's some code to import from LS3 but, after importing it, **all the example...
@FEA-eng many thanks for looking at this. I confirm your analysis, at least for @marbocub's `Example1.FCStd`. Haven't focused on @AnyOldName3's [issue-demo.zip](https://github.com/user-attachments/files/17549721/issue-demo.zip) because, as for my https://github.com/FreeCAD/FreeCAD/issues/17124#issuecomment-2445431099, I'm aware that the...
@marbocub, I have an update: The issue described in my previous https://github.com/FreeCAD/FreeCAD/issues/17124#issuecomment-2481277952 is caused by the absence of the following line in `PartDesign::Hole::execute()`, present in v0.21.2 but not in main...
Many thanks @FEA-eng for retesting! Good to know that also `Example1.FCStd` now works. I'm going to open a dedicated PR for the `PartDesign::Hole::execute()` issue, as that is a regression (in...
@marbocub can I reuse your [Example3.zip](https://github.com/user-attachments/files/17358935/Example3.zip) to develop an automatic test for the CI? I'm trying to create a model with `v0.21` that generate the same error but haven't figured...
@marbocub don't worry, I hope your event was an happy one! Anyway thank you very much for allowing us to reuse your file! I'm going right now to finally open...
@maxwxyz, @pinkavaj, I see this PR now for the first time. ATM I can't share any comments, I'll need some time to study it (or better, its effect as the...
@maxwxyz, @pinkavaj I gave a more careful look at this PR and related comments. @pinkavaj, I agree with your https://github.com/FreeCAD/FreeCAD/pull/16520#issuecomment-2465806764: ATM making `geoHistoryLevel` via Parameter doesn't look worth the effort...
@maxwxyz thanks for the ping. @povilas-ohd, while I too can confirm the issue, there's a thing I don't understand: > It was perfectly working in freecad 0.21 I tried to...