Vincenzo Calligaro

Results 70 comments of Vincenzo Calligaro

An update: I've been able to compile and run FC editing `TopoShape.h` instead of `TopoShape.cpp` so that only one file is modified. The changes I made are the following. BEFORE:...

@chennes Thanks for the update! I just compiled and tried the last force-pushed commit and everything looks working correctly. I simply tried the same steps of my previous comments on...

@chennes, I took a look at the code and haven't spotted anything strange. I was a little worried that `Tag` and `Hasher` could have been used without initializing them but...

I'll try to compile on Linux.

@chennes @wavexx I tried to compile this branch on my PC with Linux Mint 21 Cinnamon using `-DFREECAD_USE_PCH=ON` on an empty directory and I had no issues, I can compile...

Hi @chennes! I agree. Most of the new methods added for `makeElementWires` are already tested (directly or indirectly) with tests added in other PRs. If in the future we'll open...

Great work @bgbsww! I'll contribute with my discoveries/modifications. By now I think we can add: ## Changed Stuff - The file `TopoShapeEx.cpp` from RT branch is now renamed `TopoShapeExpansion` and...

Hi @Roy-043! Sure, I'll give it a look today and give you a feedback. Unfortunately I haven't studied the logic of this method before so I don't know if I'll...

So, here are the checks I did. I started reverting #14206, tried to reproduce the original error of this issue but I'm not able to reproduce it. I guess that...

Hi @maxwxyz. Probably at some point we'll need to import the related code. By now I opened a PR (#14437) that should fix the issue that made me open this...