Stuart Mumford

To be fair, in my opinion there is a big difference between Astropy using typing (needs an APE) and astropy supporting downstream packages using Astropy classes as type hints (probably...

> in the examples at https://docs.astropy.org/en/stable/api/astropy.units.quantity_input.html the typing is using the unit instance and not u.Quantity. That's because it's not using "typing" at all, it's using the function annotation syntax...

> Our current problem is that for this to be a proper type annotation When you say this what do you mean? Do you mean MyPy wouldn't work with `u.Quantity[u.m]`...

> We could do it all, I think I know how, but the scale of the problem, requiring an APE, and the time commitment on my end have thus far...

## Review checklist for @Cadair ### Conflict of interest - [x] I confirm that I have read the [JOSS conflict of interest (COI) policy](https://github.com/openjournals/joss/blob/master/COI.md) and that: I have no COIs...

I have opened a couple of issues and one PR on XRTPy, and also agreed with some of @dpshelio's comments. I think all the things are pretty minor though. The...

Hi all, I think it looks good to me. My remaining comment about the docs would be that I would like to see some kind of index of all the...

hey @tanishy7777 Thanks a lot for your work on this. I hope you don't mind, but I'm going to take it over and get it merged.

Bonus points for using spice to get sdo? 🤪

> an unfortunate consequence of having an internal coordinate transformation is that a screen will be needed if the cutout corners go beyond the limb. This is particularly upsetting if...