Dubyk Danylo

Results 9 comments of Dubyk Danylo

> This works, but it's kinda strange, because it just swallows the exception. > > The point of this `initializePromise` is to check if that service was started properly. If...

> Sorry for my confusion. Should I use `vertx.getOrCreateContext()` or not 😅? > > I guess this is the only thing left. And the adjustments to tests, depending on the...

@softcoder594 Please look at other classes and methods and try to simplify and remove redundancy in them like in `IdsResolver` and `IdsMapper` case.

@andreacastello Please look at other classes and methods and try to simplify and remove redundancy in them like in `AccountValidator` or `PlatformNameVersion`.

Reverting reverted PR: https://github.com/prebid/prebid-server/pull/3915

This error again... But I found the reason: since `relevantSegments` is a hash-based map, there is no guarantee of the order of the keys, and because of this we return...

@bsardo Yes, and it's there, but it's not shown in the diff for some reason. You can check it yourself if you try to log the outcoming request. It will...

I talked to Bret and we agreed to simplify the logic. Related pr in Java: https://github.com/prebid/prebid-server-java/pull/3796

@sbrannen it would be nice to get any updates on this 😅