Carter Francis
Carter Francis
@viljarjf Any chance you can rebase this? I think that should fix the failing test. I'm leaning twoards just merging this. It seems to work well although plotting a signal...
@viljarjf This should ve fixed if you want to rebase :)
@viljarjf I think I'm going to go ahead and merge this for the moment unless you have any reason against it. I would like to maybe come back to it...
Merging for now. (and hopefully this won't break things :))
I think that @SteffenBrinckmann has a good idea. If the function is private it would be good to add this function to the CrystalMap object. Something like a function `_to_dictionary`...
@ericpre I really like this change and think it was a long time coming. That being said I think we need to think a little bit about more how we...
@hakonanes no worries, I'll look into on Monday and I can track down the change there :) I was just thinking you might have a quick idea for what changed
@hakonanes That's fair! We can just make the 0.12.0 release and then figure this out later if you think that is a good idea. I was just trying to follow...
There is something that is currently being worked on #3030 and should be included with the 2.1.0 release sometime in the next month or so. Otherwise you can always build...
@ericpre I'll have to to think about this a little more. A seperate class would be veey nice. Unfortunately a lot of the things that make this performant are using...