Carter Francis

Results 575 comments of Carter Francis

@DorianDepriester I think ions result in slightly different atomic scattering factors. I got fairly far on adding them but just never did. If this is something you are interested in...

> From my point of view, it would indeed be an interesting feature 😉 I'll see if I can make the PR later this week and we can think about...

@hakonanes @viljarjf Any idea if there is anything to this other than adding to ionic scattering cross sections? I think this is a pretty full list ``` import numpy as...

@hakonanes I'll try to make a PR with a reference later this week!

Any movement on this lately? I can take a shot at debugging the failing test if that is helpful. Is that that only thing that is blocking this from merging?

@IMBalENce The failing test is related to the fact that there used to be a warning for trying to read a .ctf file. (And now you can!)

> I added support for a color map for the IPF markers too. This is not that useful unless the user has a high `n_best`. > > ![bilde](https://github.com/pyxem/pyxem/assets/57151700/a0d870d8-1603-4de9-980a-c695f4b5c8c4) > >...

@viljarjf This is pretty much good to go correct? I'll try to review this either today or tomorrow!

@viljarjf Perfect! I'll try to go over this later today as well then.